Skip to content

[UX Icons] Some updates in the full configuration example docs #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2024
Merged

[UX Icons] Some updates in the full configuration example docs #2226

merged 1 commit into from
Oct 1, 2024

Conversation

javiereguiluz
Copy link
Member

Q A
Bug fix? no
New feature? no
Issues - below instead -->
License MIT

I propose to also show some options with problematic characters in their names (:, -) to let readers know how to use them.

@javiereguiluz javiereguiluz added docs Improvements or additions to documentation Icons labels Sep 30, 2024
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Sep 30, 2024
norkunas
norkunas reviewed Oct 1, 2024
View reviewed changes
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Oct 1, 2024
@javiereguiluz javiereguiluz merged commit d72aa7e into symfony:2.x Oct 1, 2024
1 check was pending
@javiereguiluz javiereguiluz deleted the ux_icons_docs branch October 4, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas left review comments

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation Icons Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @Kocal @norkunas @carsonbot