Skip to content

[Twig][Icons][Map] fix wiring of ComponentRuntime #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Oct 2, 2024

Q A
Bug fix? yes
New feature? no
Issues Fix #2230
License MIT

I've opted to not add an interface and keep this extension point internal to other ux/* components for now.

@carsonbot carsonbot added Bug Bug Fix Icons Map Status: Needs Review Needs to be reviewed labels Oct 2, 2024
@kbond kbond requested a review from nicolas-grekas October 2, 2024 13:41
@kbond kbond force-pushed the feat/twig/custom-renderers branch from 38ca4a4 to aaea8a7 Compare October 2, 2024 14:05
@kbond kbond force-pushed the feat/twig/custom-renderers branch from aaea8a7 to 56ec7af Compare October 2, 2024 14:08
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Oct 2, 2024
@kbond kbond merged commit 0d97120 into symfony:2.x Oct 2, 2024
59 checks passed
@kbond kbond deleted the feat/twig/custom-renderers branch October 2, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Icons Map Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TwigComponentExtension shouldn't hardcode (broken) service locator
3 participants