[Icons] Prepare lock / warmup optimization #2351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnandre
added a commit
to smnandre/ux
that referenced
this pull request
Nov 8, 2024
First usage of symfony#2351 with the import command Next steps: * lock * warm-up :)
Kocal
reviewed
Nov 8, 2024
src/Icons/src/Iconify.php
Outdated
Comment on lines
97
to
105
| throw new \InvalidArgumentException('Invalid icon names.'); | ||
| } | ||
|
|
||
| // 500 chars max | ||
| // 42 chars: https://api.iconify.design/mdi.json?icons= | ||
| if (450 < \strlen($queryString)) { | ||
| throw new \InvalidArgumentException('The query string is too long.'); |
There was a problem hiding this comment.
Please use dedicated exception classes
There was a problem hiding this comment.
Is the plan to catch this? (I typically only add named exceptions if this is the case - or it's realistic an end-user would want to catch)
There was a problem hiding this comment.
Nah I don't think so, but I like to have dedicated exceptions and also a base exception class per package (like they do on Symfony components)
There was a problem hiding this comment.
Not on every component to be far... ;)
Yet I kinda agree to use custom exception but this should be done in a dedicated PR i think, carefully selecting the one we want to "migrate" and the one we do not.
To explain myself here, this is internal and "should never" happen.
But as we all know what "should never" means... i get your point.
Kocal
approved these changes
Nov 8, 2024
carsonbot
added
Status: Reviewed
carsonbot
added
Status: Needs Review
smnandre
force-pushed
the
feat/fetch-icons
branch
from
2d57049 to
218c000
Compare
kbond
approved these changes
Nov 8, 2024
carsonbot
added
Status: Reviewed
smnandre
added a commit
to smnandre/ux
that referenced
this pull request
Nov 9, 2024
First usage of symfony#2351 with the import command Next steps: * lock * warm-up :)
smnandre
added a commit
that referenced
this pull request
Nov 10, 2024
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Icons] Fetch icons in batch in Import command | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Issues | Fix #... | License | MIT First usage of #2351 with the import command --- **Update:** - add icons counts (imported / total) - handle same-prefix icons per batch - improve visual feedback <img width="878" alt="Capture d’écran 2024-11-09 à 19 26 16" src="https://github.com/user-attachments/assets/fc6c377e-ba40-43f3-b62a-0070ba14125b"> --- Next ones: * lock * warm-up Commits ------- 88d24e0 [Icons] Fetch icons in batch in Import command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method needed for both