[CI] Fix and display changed dist files in the CI #2503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Reviewed
smnandre
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on https://github.com/symfony/stimulus-bridge, I've added a new job CI that shows when dist files are up-to-date or need to be build.
No surprise, I re-used what was on UX, but I found it was not correct: https://github.com/symfony/stimulus-bridge/actions/runs/12743300005/job/35512968204?pr=96
The command that checks if files are up-to-date fails, to me it is not working as expected.
Instead, I've simplified things and added a
git diffto display the changes:WDYT?