Update README deprecated "webpackMode" in favor of "fetch" #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After @weaverryan symfony/stimulus-bridge#15 PR Encore complains: `The "webpackMode" config key is deprecated in controllers.json. Use "fetch" instead, set to either "eager" or "lazy".`
weaverryan
approved these changes
Mar 4, 2021
weaverryan
reviewed
Mar 4, 2021
| @@ -61,7 +61,7 @@ the `@symfony/ux-dropzone/src/style.css` autoimport to `false`: | |||
| "@symfony/ux-dropzone": { | |||
| "dropzone": { | |||
| "enabled": true, | |||
| "webpackMode": "eager", | |||
| "fetch": "eager", | |||
There was a problem hiding this comment.
For clarification to others, the package.json files themselves in this repo still have "webpackMode": "eager". However, that is just for backwards-compat with stimulus-bridge 1. symfony/flex 1.12.0 (thanks to symfony/flex#735) will read the webpackMode but actually put fetch into your controllers.json file.
tl;dr - this fix is correct
There was a problem hiding this comment.
But the Readme stay confusing because don't tell anything about this.
Maybe a note could be added at least to clarify this.
dunglas
approved these changes
Mar 11, 2021
|
Thank you @kl3sk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After @weaverryan symfony/stimulus-bridge#15 PR
Encore complains:
The "webpackMode" config key is deprecated in controllers.json. Use "fetch" instead, set to either "eager" or "lazy".