Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): make it explicit that Ether as bond must be deposited beforehand. #19028

Merged
merged 7 commits into from
Mar 4, 2025
Merged

refactor(protocol): make it explicit that Ether as bond must be deposited beforehand. #19028

merged 7 commits into from
Mar 4, 2025

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Mar 4, 2025

Another fix is to make proposeBatch payable in TaikoInbox and TaikoWrapper (and some other files), which I do not prefer.

@dantaik dantaik changed the title fix(protocol): make explicit that Ether as bond must be deposited beforehand. fix(protocol): make it explicit that Ether as bond must be deposited beforehand. Mar 4, 2025
@dantaik dantaik marked this pull request as ready for review March 4, 2025 03:45
@dantaik dantaik requested review from davidtaikocha and smtmfft March 4, 2025 03:45
@dantaik dantaik enabled auto-merge (squash) March 4, 2025 03:46
@dantaik dantaik changed the title fix(protocol): make it explicit that Ether as bond must be deposited beforehand. refactor(protocol): make it explicit that Ether as bond must be deposited beforehand. Mar 4, 2025
@dantaik dantaik disabled auto-merge March 4, 2025 06:50
@dantaik dantaik enabled auto-merge (squash) March 4, 2025 07:33
@dantaik dantaik merged commit a7cf79e into main Mar 4, 2025
6 checks passed
@dantaik dantaik deleted the fix_ether_as_bond branch March 4, 2025 16:39
@taiko-kitty taiko-kitty mentioned this pull request Mar 4, 2025
Merged
@dantaik dantaik mentioned this pull request Mar 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@smtmfft smtmfft Awaiting requested review from smtmfft

@AnshuJalan AnshuJalan Awaiting requested review from AnshuJalan

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @smartprogrammer93 @davidtaikocha