Skip to content

[8pt] Indexes: Revise create_index() page #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Onvember opened this issue Feb 12, 2021 · 0 comments · Fixed by #1831
Closed

[8pt] Indexes: Revise create_index() page #1820

Onvember opened this issue Feb 12, 2021 · 0 comments · Fixed by #1831
Assignees
@Onvember
Labels
reference [location] Tarantool manual, Reference part rewrite [nature] Revise existing text for structure/phrasing/terms

Comments

@Onvember
Copy link
Contributor

  • “Details about index field types” и “Index field types to use in space_object:create_index()” выглядят как одно и то же. Считаю, что лучше оставить только таблицу
  • код-блок с примерами про JSON-индексы можно разбить на два
  • в [*]-секции хотели сделать маркированный список, но не получилось, надо исправить
  • пересмотреть пример для [*]-секции (например, в what’s new он более понятный)
  • переписать куски с |br|, чтобы был либо связные абзацы, либо уместный список
  • решить, какие подсекции оставить на этой странице, а какие перенести в другое место (считаю, что нужно перенести последние 4 подсекции)
@Onvember Onvember added reference [location] Tarantool manual, Reference part S (small) rewrite [nature] Revise existing text for structure/phrasing/terms labels Feb 12, 2021
@Onvember Onvember self-assigned this Feb 12, 2021
@Onvember Onvember changed the title Refactor create_index() page [8pt] Refactor create_index() page Feb 12, 2021
@NickVolynkin NickVolynkin linked a pull request Feb 16, 2021 that will close this issue
gh-1820 revise create_index() page #1831
Merged
Onvember added a commit that referenced this issue Feb 16, 2021
@Onvember @NickVolynkin
gh-1820 revise create_index() page (#1831)
d194f06 
* update text wrapping, titles and example formatting

* make list-table for details about indexed fields types

* Apply suggestions from code review

* small improvements

Co-authored-by: Nick Volynkin <nick.volynkin@gmail.com>
@Onvember Onvember changed the title [8pt] Refactor create_index() page [8pt] Indexes: Revise create_index() page Mar 16, 2021
This was referenced Mar 16, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Onvember Onvember

Labels
reference [location] Tarantool manual, Reference part rewrite [nature] Revise existing text for structure/phrasing/terms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-1820 revise create_index() page tarantool/doc
1 participant
@Onvember