Skip to content

Fix response obj string repr in case of no data #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2019
Merged

Fix response obj string repr in case of no data #145

merged 1 commit into from
Jun 10, 2019

Conversation

denis-ignatenko
Copy link
Contributor

Resolves #139

@denis-ignatenko @Totktonada
Fix response obj string repr in case of no data
a02471e 
For example an Connection::authenticate() response does no contain a
data. This leads to an exception when working with the connection from
interactive python console.

Fixes #139.
@Totktonada Totktonada force-pushed the fix-empty-_data-in-response-for-interactive-console branch from 02188ef to a02471e Compare June 10, 2019 12:23
@Totktonada
Copy link
Member

I'm okay with the code. Updated the commit message with more information.

@Totktonada Totktonada merged commit 0b969fd into master Jun 10, 2019
@Totktonada Totktonada deleted the fix-empty-_data-in-response-for-interactive-console branch June 10, 2019 14:05
DifferentialOrange added a commit that referenced this pull request Nov 30, 2022
@DifferentialOrange
api: custom packer and unpacker factories
7afb69d 
After this patch, user may pass `packer_factory` and `unpacker_factory`
options to a connection. They will be used instead of the default ones.
`packer_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Packer object.
`unpacker_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Unpacker
object. `packer_factory` supersedes `encoding` option.
`unpacker_factory` supersedes `encoding` and `use_list` options. User
may implement `encoding` and `use_list` support in its custom packer or
unpacker if they wish so. User may refer to request submodule
`packer_factory` and response submodule `unpacker_factory` as an example
(these factories are used by default.)

Closes #145, #190, #191
@DifferentialOrange DifferentialOrange mentioned this pull request Nov 30, 2022
Merged
DifferentialOrange added a commit that referenced this pull request Nov 30, 2022
@DifferentialOrange
api: custom packer and unpacker factories
9032f9a 
After this patch, user may pass `packer_factory` and `unpacker_factory`
options to a connection. They will be used instead of the default ones.
`packer_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Packer object.
`unpacker_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Unpacker
object. `packer_factory` supersedes `encoding` option.
`unpacker_factory` supersedes `encoding` and `use_list` options. User
may implement `encoding` and `use_list` support in its custom packer or
unpacker if they wish so. User may refer to request submodule
`packer_factory` and response submodule `unpacker_factory` as an example
(these factories are used by default.)

Closes #145, #190, #191
DifferentialOrange added a commit that referenced this pull request Nov 30, 2022
@DifferentialOrange
api: custom packer and unpacker factories
d158728 
After this patch, user may pass `packer_factory` and `unpacker_factory`
options to a connection. They will be used instead of the default ones.
`packer_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Packer object.
`unpacker_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Unpacker
object. `packer_factory` supersedes `encoding` option.
`unpacker_factory` supersedes `encoding` and `use_list` options. User
may implement `encoding` and `use_list` support in its custom packer or
unpacker if they wish so. User may refer to request submodule
`packer_factory` and response submodule `unpacker_factory` as an example
(these factories are used by default.)

Closes #145, #190, #191
DifferentialOrange added a commit that referenced this pull request Dec 1, 2022
@DifferentialOrange
api: custom packer and unpacker factories
f59e532 
After this patch, user may pass `packer_factory` and `unpacker_factory`
options to a connection. They will be used instead of the default ones.
`packer_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Packer object.
`unpacker_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Unpacker
object. `packer_factory` supersedes `encoding` option.
`unpacker_factory` supersedes `encoding` and `use_list` options. User
may implement `encoding` and `use_list` support in its custom packer or
unpacker if they wish so. User may refer to request submodule
`packer_factory` and response submodule `unpacker_factory` as an example
(these factories are used by default.)

Closes #145, #190, #191
DifferentialOrange added a commit that referenced this pull request Dec 1, 2022
@DifferentialOrange
api: custom packer and unpacker factories
51db95b 
After this patch, user may pass `packer_factory` and `unpacker_factory`
options to a connection. They will be used instead of the default ones.
`packer_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Packer object.
`unpacker_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Unpacker
object. `packer_factory` supersedes `encoding` option.
`unpacker_factory` supersedes `encoding` and `use_list` options. User
may implement `encoding` and `use_list` support in its custom packer or
unpacker if they wish so. User may refer to request submodule
`packer_factory` and response submodule `unpacker_factory` as an example
(these factories are used by default.)

Closes #145, #190, #191
DifferentialOrange added a commit that referenced this pull request Dec 1, 2022
@DifferentialOrange
api: custom packer and unpacker factories
1154b3d 
After this patch, user may pass `packer_factory` and `unpacker_factory`
options to a connection. They will be used instead of the default ones.
`packer_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Packer object.
`unpacker_factory` is expected to be a function with the only one
parameter: connection object, which returns a new msgpack.Unpacker
object. `packer_factory` supersedes `encoding` option.
`unpacker_factory` supersedes `encoding` and `use_list` options. User
may implement `encoding` and `use_list` support in its custom packer or
unpacker if they wish so. User may refer to request submodule
`packer_factory` and response submodule `unpacker_factory` as an example
(these factories are used by default.)

Closes #145, #190, #191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No _data in response in some cases
2 participants
@denis-ignatenko @Totktonada