vinyl/gh.test.lua does not check whether fibers are finished #106
Comments
|
I looked at the test, because I found the following line in logs:
Despite the error the test passes. (But I don't know why this situation occurs. The variable is declared before reading.) I'm on Linux, tarantool is built in Debug mode. |
kyukhin
changed the title
Found that in one previous commit 42c64d0 ('test: fix hanging of vinyl/gh.test.lua') Was mistakenly made such change: -while finished ~= 2 do fiber.sleep(0.01) end +test_run:wait_cond(function() return finished ~= 2 end) And the logic of the check was broken. This patch fixes it. Part of #5141 Fixes tarantool/test-run#261 Closes tarantool/tarantool-qa#106
Found that in one previous commit 42c64d0 ('test: fix hanging of vinyl/gh.test.lua') Was mistakenly made such change: -while finished ~= 2 do fiber.sleep(0.01) end +test_run:wait_cond(function() return finished ~= 2 end) And the logic of the check was broken. This patch fixes it. Part of #5141 Fixes tarantool/test-run#261 Part of tarantool/tarantool-qa#106
Found issue: 2021-06-21 08:12:25.904 [2459810] main/125/lua utils.c:1014 E> LuajitError: [string "_ = fiber.create(function() while cont do..."]:1: attempt to concatenate global 'cont' (a boolean value) Corrected code to avoid of it - changed boolean to integer. Closes tarantool/tarantool-qa#106
Found that in one previous commit 42c64d0 ('test: fix hanging of vinyl/gh.test.lua') Was mistakenly made such change: -while finished ~= 2 do fiber.sleep(0.01) end +test_run:wait_cond(function() return finished ~= 2 end) And the logic of the check was broken. This patch fixes it. Part of #5141 Fixes tarantool/test-run#261 Part of tarantool/tarantool-qa#106
Found that in one previous commit 42c64d0 ('test: fix hanging of vinyl/gh.test.lua') Was mistakenly made such change: -while finished ~= 2 do fiber.sleep(0.01) end +test_run:wait_cond(function() return finished ~= 2 end) And the logic of the check was broken. This patch fixes it. Part of #5141 Fixes tarantool/test-run#261 Part of tarantool/tarantool-qa#106 (cherry picked from commit e07b905)
Found that in one previous commit 42c64d0 ('test: fix hanging of vinyl/gh.test.lua') Was mistakenly made such change: -while finished ~= 2 do fiber.sleep(0.01) end +test_run:wait_cond(function() return finished ~= 2 end) And the logic of the check was broken. This patch fixes it. Part of #5141 Fixes tarantool/test-run#261 Part of tarantool/tarantool-qa#106 (cherry picked from commit e07b905)
Moved to separate issue to be able to close this one: |
|
The main issue was fixed in tarantool/tarantool#6168. |
The test case was added in tarantool/tarantool@e576ca9
And became broken in tarantool/tarantool@42c64d0:
The condition was not reverted.
The text was updated successfully, but these errors were encountered: