Mefi v8 134 fix rebased #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original addons/esm test was failing when building the addon after updating V8 to v13.4 on Windows. After an investigation, it was clear that the targets of the binding.gyp cannot coexist together so it was divided into 2 sets of 2 targets with no overlapping.
|
@targos here is the CI run on Windows. Everything is green. I'd say it's ready for the review now. |
6 tasks
|
Thank you! |
targos
pushed a commit
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixes needed to enable compiling V8 v13.4 on Windows with MSVC. The last commit fixes an issue with running native tests (more details in its commit message) on VS2022 for both MSVC and ClangCL.
@targos, although I tested this in the CI manually and everything seems to be good. I'd still like to run it through CI regularly once the restriction is lifted, before merging.