Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tauri-build): set CompanyName for Windows #12958

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Enigmatrix
Copy link

Set CompanyName for the produced .exe files for Windows. Follows the documentation and uses the second element on bundleId if publisher is not set.

@Enigmatrix Enigmatrix requested a review from a team as a code owner March 12, 2025 10:58
Copy link
Contributor

Package Changes Through a0660fc

There are 6 changes which include tauri with minor, @tauri-apps/api with minor, tauri-runtime-wry with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.3.0 2.4.0
tauri-bundler 2.2.4 2.2.5
tauri-runtime-wry 2.4.1 2.5.0
tauri 2.3.1 2.4.0
@tauri-apps/cli 2.3.1 2.3.2
tauri-cli 2.3.1 2.3.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir
Copy link
Member

Why not set the Publisher field instead? Why should we fallback, is sitting it necessary?

@Enigmatrix
Copy link
Author

CompanyName (File Version Info, see winresource) and Publisher (for MSI) seem to be different. Seems like its not set during Tauri builds, which this PR fixes. Letting it be set makes it appear different in Startup Apps, for example:
image

compared to without this change:
image

@amrbashir
Copy link
Member

So sitting it is not necessary and should be left to the user to decide. If they want, they should set the publisher field, otherwise we don't fallback and keep it empty.

@amrbashir
Copy link
Member

This PR is good, I am saying we just use the publisher field without fallback.

@Enigmatrix
Copy link
Author

Oh, I see. I was following the documentation here:

image

and I saw that other usages of the publisher did the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

2 participants