-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-VALIDATION_COORDINATESTERRESTRIALMARINE_CONSISTENT #51
Comments
Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet: |
Comment by Paul Morris (@chicoreus) migrated from spreadsheet: |
Comment by Paul Morris (@chicoreus) migrated from spreadsheet: |
Comment by Christian Gendreau (@cgendreau) migrated from spreadsheet: |
Comment by Paul Morris (@chicoreus) migrated from spreadsheet: |
This probably needs further discussion. There are two ways this can be done. Some earlier discussion seemed to indicate that it may be better to use the taxon to decide if it is Marine or not - i.e. go the OBIS way and use WORMS - and basically decide on a Taxon basis. Alternatively (and harder to implement) is to use similar techniques to #73 and use a GIS layer. If the latter, then we probably need to add the 3km buffer - but what about things in estuaries (where coastlines are particularly unreliable). I think I favour using the taxon to decide, using WORMS. Whatever we do it needs to be rewritten. |
Also see comment by @iDigBioBot above |
The test is certainly useful if it can flag species in a wrong location and marine vs non-marine is the most broad first cut. This test requires a) the habitat identification of the taxon and b) the location using dwc:decimalLatitude and dwc:decimalLongitude and (c), a spatial buffer. (a) could be iffy if is it based on WORMS or IRMNG. |
Note that if you are using layers for the marine/terrestrial boundaries - the scale of the land/water interface in the EEZ layers on marineregions.org is a lot more course than that of the country (and hence land/marine interface) GADM country boundaries, for example so I would suggest the latter. |
Is the EEZ relevant here? All we need to know is land vs water? Maybe. Australia has a category called 'External territories' that includes a bunch of islands like Cocos, Heard, McDonald, Norfolk and I guess from https://www.ga.gov.au/scientific-topics/marine/jurisdiction/maritime-boundary-definitions that these are part of the EEZ. |
The GADM country layers should have the islands, so the EEZ is probably not as relevant and is at a muh worse scale. I would just use GADM. |
Looking at the Expected Response in this one - it is not clear if we are using geographic boundaries or relying on taxon IRMNG and the OBIS codes to determine isMarine. As written we seem to be having bets both ways. |
As far as I am concerned, there are at least two bdq:sourceAuthority references here. The first is either WORMS or IRMNG and the second is GADM. A potential third may be EEZs. I cannot see why we don't have an EXTERNAL_PREREQUISITES_NOT_MET We again have the potential problem of spatial buffers. As per #73 (and others), buffering makes for serious complications. I would be happier to accept the false positive here if we skip the complexities (and put scenarios with buffers in Notes) as a VALIDATION, than I would for an AMENDMENT as in #73. |
It depends on whether you go the spatial route - then GADM, if you go the taxon route then IRMNG - I think we have to use one or the other and not both? The IRMNG I think includes the OBIS Codes for marine, freshwater, brackish, or terrestrial - perhaps these could be used in some way. If you go the Spatial route, then you have the problem of fuzzy coastlines (so not going to be accurate within 3km if using global layers and not a localised GIS), and the IRMNG may thus be more accurate. It may need be something that is tested against some real data. If we go the taxon route, then we are at least consistent with OBIS. |
OBIS uses the habitat values from WoRMS not IRMNG. A taxa can have more than one value. Only those tagged with marine appear in the OBIS portal. OBIS does report on suspect terrestrial locations but the data still appears. Obviously if it is a seabird it can be inland - migrating or nesting. We have seen terrestrial birds fly south in the southern ocean (likely never to return) yet a valid observation. Many observations of marine animals are done from the coast so appear in the wrong spot. Salt water crocs travel up rivers so appear inland even if tagged as marine. I think the WoRMS taxonomic editors are more likely to tag the taxa correctly as marine versus using observation records to define 'marine' |
Thanks @davewatts3 - very valuable contribution. |
Even biome is too generic. I vote for leaving it as is. |
OK as is - we have TERRESTRIALMARINE defined in #152 |
I suggest the Description: 'Does the marine/non-marine biome of a taxon from the bdq:sourceAuthority match the biome at the location given by the coordinates?' in place of: 'Does the marine/nonmarine status of a taxon from bdq:sourceAuthority[taxonomyismarine] match the location given by the coordinates?' |
Source Authority of land and islands merged to "bdq:sourceAuthority[geospatialland] default = the union of "NaturalEarth 10m-physical-vectors for Land" [https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/physical/ne_10m_land.zip] and "NaturalEarth Minor Islands" [https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/physical/ne_10m_minor_islands.zip]" |
Restructured Parameter(s) and Source authority |
Updated Expected Response, Parameter(s), Source Authority and Specification Last Updated to replace: |
ost Zoom 11/7/2023, I have aligned the Source Authority with the suggested syntax: bdq:taxonIsMarine default = "WORMS" [https://www.marinespecies.org/aphia.php?p=webservice] bdq:geospatialLand default = the spatial union of "NaturalEarth 10m-physical-vectors for Land" [https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/physical/ne_10m_land.zip] and "NaturalEarth Minor Islands" [https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/physical/ne_10m_minor_islands.zip] to bdq:taxonIsMarine default = "World Register of Marine Organisms (WORMS") {[https://www.marinespecies.org/]} |
On Mon, 10 Jul 2023 19:54:57 -0700 Lee Belbin ***@***.***> wrote:
bdq:taxonIsMarine default = "World Register of Marine Organisms
(WORMS") {[https://www.marinespecies.org/]} {Web service
[https://www.marinespecies.org/aphia.php?p=webservice]}
That should be "World Register of Marine Organisms (WoRMS)". (lower case o in WoRMS, close parenthesies before the quote).
|
This test should have Data Quality Dimension "Consistency" rather than "Conformance". Edited. |
Hi,
I believe there is a typo, WoRMS is "World Register of Marine |
Thanks @ymgan. Corrected. |
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField" and "Output Type" to "TestType". |
Changed "was" to "is" to align with standard phrasing in ER as in "INTERNAL_PREREQUISITES_NOT_MET if xxx is EMPTY" |
The default source authority identifier must be a single string, it can't be a list of source authorities. Thus change from: {bdq:geospatialLand default = The spatial union of "NaturalEarth 10m-physical-vectors for Land" [https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/physical/ne_10m_land.zip] and "NaturalEarth Minor Islands" [https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/physical/ne_10m_minor_islands.zip]} To: {bdq:geospatialLand default = "Union of NaturalEarth 10m-physical-vectors for Land and NaturalEarth Minor Islands" [https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/physical/ne_10m_land.zip], [https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/physical/ne_10m_minor_islands.zip]} |
…TERRESTRIALMARINE. Including sci_name_qc library as dependency to provide WoRMSService for looking up names and habitats in WoRMS.
Expected Response changed from From EXTERNAL_PREREQUISITES_NOT_MET if either bdq:taxonomyIsMarine or bdq:geospatialLand are not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:scientificName is EMPTY or the marine/non-marine status of the taxon is not interpretable from bdq:taxonomyIsMarine or the values of dwc:decimalLatitude or dwc:decimalLongitude are EMPTY; COMPLIANT if the taxon marine/non-marine status from bdq:taxonomyIsMarine matches the marine/non-marine status of dwc:decimalLatitude and dwc:decimalLongitude on the boundaries given by bdq:geospatialLand plus an exterior buffer given by bdq:spatialBufferInMeters; otherwise NOT_COMPLIANT to EXTERNAL_PREREQUISITES_NOT_MET if either bdq:taxonomyIsMarine or bdq:geospatialLand are not available; INTERNAL_PREREQUISITES_NOT_MET if (1) dwc:scientificName is EMPTY or (2) the values of dwc:decimalLatitude or dwc:decimalLongitude are EMPTY or (3) if bdq:assumptionOnUnknownHabitat is NoAssumption and the marine/non-marine status of the taxon is not interpretable from bdq:taxonomyIsMarine; COMPLIANT if (1) the taxon marine/non-marine status from bdq:taxonomyIsMarine matches the marine/non-marine status of dwc:decimalLatitude and dwc:decimalLongitude on the boundaries given by bdq:geospatialLand plus an exterior buffer given by bdq:spatialBufferInMeters or (2) if the marine/non-marine status of the taxon is not interpretable from bdq:taxonomyIsMarine and the taxon marine/non-marine status from bdq:assumptionOnUnknownHabitat matches the marine/non-marine status of dwc:decimalLatitude and dwc:decimalLongitude on the boundaries given by bdq:geospatialLand plus an exterior buffer given by bdq:spatialBufferInMeters ; otherwise NOT_COMPLIANT | This was to allow Terrestrial values to be COMPLIANT whereas previously anything not in WoRMS for example to report INTERNAL_PREREQUISITES_NOT_MET Note added to report that current implementation tests teat "brackish" in WoRMS as both marine and terrestrial. Updated Specification Last Updated |
Changed "bdq:taxonomyIsMarine" to "bdq:taxonIsMarine" throughout |
…patial check against land, adding more types of name matches as matching. Adding a minimal unit test.
Changed name to make consistent TERM_ACTION string, with an action. |
The text was updated successfully, but these errors were encountered: