-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-AMENDMENT_SCIENTIFICNAMEID_FROM_TAXON #57
Comments
Comment by Paul Morris (@chicoreus) migrated from spreadsheet: |
We should add taxonRank to the list of fields for this and #70 . It is especially important for the interpretation of monomials in scientific name absent other supporting data. |
@godfoder I concur. Do we need to specify a more complex set of prerequisites? |
A couple of issues for implementation: Acton to take when taxonID is NOT_EMPTY: The specification is mute on what action to take when dwc:taxonID has a value. Since other tests specify CHANGED only if term that is proposed to be amended is NOT_EMPTY, the implication is that an amendment is to be proposed, for purposes such as conforming taxonID values to a national authority. This should probably be spelled out in the notes section. Extraneous terms in the list of Information Elements: The specification states that a proposed amendment should be based on "on the basis of the value of the lowest ranking not EMPTY taxon classification terms dwc:scientificName, dwc:scientificNameAuthorship, dwc:kingdom, dwc:phylum, dwc:class, etc.", with @godfoder's comment clearly indicating that taxonRank should be included in this list. The notes imply that none of the other ID terms (dwc:scientificNameID, dwc:acceptedNameUsageID, dwc:originalNameUsageID, dwc:taxonConceptID) should be included in this analysis, so it seems that they shouldn't be included in the informationElements, unless there is a clear specification of how to include them to infer a value of taxonID. Also, neither dwc:higherClassification nor dwc:vernacularName are included in the specification, and thus don't seem to fit in the list of information elements. |
Further to the logic of @chicoreus - I don't understand the inclusion of dwc:scientificNameAuthorship as it isn't a taxon classification term in the hierarchy, and that and that field alone could not supply a taxonID. |
@ArthurChapman I see scientificNameAuthorship as an essential term for identifying which taxonID to use, it can often disambuguate homonyms and if the authorship string associated with the source record for taxonID isn't the same as the authorship string in a record under consideration, then something likely isn't correct and an assertion of of a taxonID match is not a good one to make. |
@chicoreus - that is correct, but it may need us to reword the test, because as written, I don't see how that field could work as dwc:scientificNameAuthorship is not strictly a classification term. dwc:scientificName should include the authorship and thus could be used to resolve the taxonID. It probably applies to a different test to use the dwc:scientificNameAuthorship to fix dwc:scientificName but as this test is written then the dwc:scientificNameAuthorship on its own doesn't work. I don't see that term belong in this test. |
I have to defer to @chicoreus, @ArthurChapman and @tucotuco on this. I will apply @ArthurChapman's latest Expected Response, with a few more tweaks. |
Are we all happy with the specifications on this one now? |
Changed "AMENDED" to "FILLED_IN" in accordance with discussions April 16. |
Amended Example to align with @chicoreus comments in email 17th June 2022. |
…IF backbone has more than one record for the same taxon with identical spelling of name and authorship. Excluding name matches that have an accepted key that is the same as a key allready matched.
…y as a string retaining the responsibility of interpreting a user provided string in the source authority object, but constructing that object after the call to the test method instead of before, allowing, as with darwin core term inputs, the method APIs for the tests to use just strings.
So the text of cultivarEpithet should also be found in scientificName?
…On Sun, 13 Mar 2022 22:37:49 -0700 John Wieczorek ***@***.***> wrote:
> 1. on treatment of dwc:cultivarEpithet different to
> dwc:infraspecificEpithet (I believe they shouldn't be differently
> treated - @tucotuco to clarify use of dwc:cultivarEpithet) - see my
> comment of two days ago
My understanding is that a cultivarEpithet should be as determinant
of a Taxon as an infraspecificEpithet is and treated in the same way.
|
Yes, I think it should. But for a definitive answer it is best to ask someone such as @mdoering and @ nielsklazenga. |
@nielsklazenga - any comments? [space inadvertently included in last post by @tucotuco |
Regarding |
Why don't we have an "EXTERNAL_PREREQUISITES_NOT_MET" if we reference bdq:sourceAuthority?! I've added it as otherwise it will stuff up the test data work. |
Changed Parameter(s) to "bdq:sourceAuthority" as per discussions 12th June 2023 |
I have added to the Notes to be consistent with #71: "When referencing a GBIF taxon by GBIF's identifier for that taxon, use the the pseudo-namespace "gbif:" and the form "gbif:{integer}" as the value for dwc:taxonID." |
Will need to include the new terms dwc:superfamily, dwc:tribe, dwc:subtribe tdwg/dwc#65 tdwg/dwc#45 tdwg/dwc#46 |
Added the terms dwc:superfamily, dwc:tribe, dwc:subtribe to the Information elements and Expected response, and updated Specification Last Updated. On this one, please check my Expected response. |
Amended Source Authority values to align with @chicoreus syntax From bdq:sourceAuthority default = "GBIF Backbone Taxonomy" [https://doi.org/10.15468/39omei] | to bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]} |
…pecifications. Addressed tdwg/bdq#57 AMENDMENT_TAXONID_FROM_TAXON Updated metadata, ProvidesVersion and Specification annotations. Further updates to implementation for superfamily, tribe, and subtribe. Removed reviewed stub method.
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField" and "Output Type" to "TestType". |
…est to reflect change from taxonID to scientificNameID as the expected external identifier reference for a taxon.
The text was updated successfully, but these errors were encountered: