Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_BASISOFRECORD_NOTEMPTY #58

Closed
iDigBioBot opened this issue Jan 5, 2018 · 9 comments
Closed

TG2-VALIDATION_BASISOFRECORD_NOTEMPTY #58

iDigBioBot opened this issue Jan 5, 2018 · 9 comments
Labels
CODED Completeness CORE TG2 CORE tests OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID ac2b7648-d5f9-48ca-9b07-8ad5879a2536
Label VALIDATION_BASISOFRECORD_NOTEMPTY
Description Is there a value in dwc:basisOfRecord?
TestType Validation
Darwin Core Class Record-level
Information Elements ActedUpon dwc:basisOfRecord
Information Elements Consulted
Expected Response COMPLIANT if dwc:basisOfRecord is bdq:NotEmpty; otherwise NOT_COMPLIANT
Data Quality Dimension Completeness
Term-Actions BASISOFRECORD_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2023-09-17
Examples [dwc:basisOfRecord="PreservedSpecimen": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:basisOfRecord is bdq:NotEmpty"]
[dwc:basisOfRecord="": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:basisOfRecord is bdq:Empty"]
Source TG2
References
Example Implementations (Mechanisms) Kurator/FilteredPush rec_occur_qc Library DOI: 10.5281/zenodo.14968501
Link to Specification Source Code https://github.com/FilteredPush/rec_occur_qc/blob/v1.0.1/src/main/java/org/filteredpush/qc/metadata/DwCMetadataDQ.java#L207
Notes
@iDigBioBot
Copy link
Collaborator Author

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet:
Added post scoring for consistency

@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 19, 2018
@iDigBioBot iDigBioBot changed the title TG2-VALIDATION_BASISOFRECORD_NULL TG2-VALIDATION_BASISOFRECORD_EMPTY Jan 29, 2018
@Tasilee Tasilee added the Issue A potential issue label Aug 14, 2018
@Tasilee Tasilee changed the title TG2-VALIDATION_BASISOFRECORD_EMPTY TG2-NOTIFICATION_BASISOFRECORD_EMPTY Aug 15, 2018
@Tasilee Tasilee changed the title TG2-NOTIFICATION_BASISOFRECORD_EMPTY TG2-VALIDATION_BASISOFRECORD_EMPTY Aug 22, 2018
@ArthurChapman ArthurChapman added Validation and removed Issue A potential issue labels Aug 22, 2018
@tucotuco
Copy link
Member

Agreed at TDWG 2018 DQIG meeting that the test is a Validation and the name TG2-VALIDATION_BASISOFRECORD_EMPTY is satisfactory.

@Tasilee
Copy link
Collaborator

Tasilee commented Oct 5, 2020

Generating test data for this and wonder if we should have an 'INTERNAL_PREREQUISITES_NOTMET if dwc:basisOfRecord is not provided'? My feeling is "no" as this would be equivalent to EMPTY?

@ArthurChapman
Copy link
Collaborator

Agreed @Tasilee

@chicoreus
Copy link
Collaborator

@Tasilee I concur. To allow for implementations where the test is unable to tell if the field was provided as a data element for a record or not, we've included term not provided within the definition of empty, so tests should simply specify what state should be returned for empty and not separately make an assertion about a term not being provided.

Tasilee added a commit that referenced this issue Oct 7, 2020
In accordance with #189, added test data testdata_VALIDATION_BASISOFRECORD_EMPTY_#58.csv for #58
@Tasilee
Copy link
Collaborator

Tasilee commented Mar 2, 2022

Going through the test data, dwc:basisOfRecord="[non-printing characters]" with the current Expected Response would suggest to me to return "COMPLIANT": A sort of false positive (which is sort of ok :). Are we happy with that or are we suggesting something like "interpreted as a text string"...or similar? I want to keep this simple.

@ArthurChapman
Copy link
Collaborator

With all the "[non-printing characters]" we have treated them as EMPTY (and therefore NON_COMPLIANT) - we have been consistent - I guess it is because a human can't see them - they don't print. They would be easy to fix if we change that as they are all treated exactly the same in the EMPTY/NOT_EMPTY tests. This is different to "[Null]" where there is something - like "-n/", "null", "NULL", "9999", etc. where this a value and thus it is NOT_EMPTY and thus COMPLIANT

@tucotuco
Copy link
Member

tucotuco commented Mar 2, 2022 via email

@Tasilee Tasilee changed the title TG2-VALIDATION_BASISOFRECORD_EMPTY TG2-VALIDATION_BASISOFRECORD_NOTEMPTY Mar 22, 2022
chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Aug 29, 2022
…nimal unit tests for those tests. Implementations for tdwg/bdq#94 tdwg/bdq#58 tdwg/bdq#103 tdwg/bdq#99 tdwg/bdq#47 and tdwg/bdq#117 added utility class with method to test if empty.  Changing implemented methods to static.
@Tasilee
Copy link
Collaborator

Tasilee commented Sep 16, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField" and "Output Type" to "TestType".

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CODED Completeness CORE TG2 CORE tests OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Projects
None yet
Development

No branches or pull requests

5 participants