Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack; Removes most hardcoded HackMIT references #80

Closed
wants to merge 42 commits into from

Conversation

SheaBelsky
Copy link

@SheaBelsky SheaBelsky commented Jul 14, 2018

Resolves most of #79 . There are two places where these hardcoded instances cannot be removed:

  • The index.html root file, which doesn't inherit from any Angular controller to the best of my knowledge
  • The text.hbs email templates. Variables can be passed into these templates, but I don't even see where these templates are referenced. Would be easy to change.

All references to a globally installed version of Gulp were changed to instead reference the locally installed version of Gulp. I also moved the Gulp dependencies to devDependencies (there was some duplication) and replaced a deprecated dependency (gulp-minify-css => gulp-clean-css).

The platform now runs on Webpack; Gulp and Babel have had both of their primary functions rolled into Webpack. Right now all the dependencies are installed and Webpack just copies them over as-is. Ideally, the dependencies would be imported where necessary in each file, and then Webpack will manage them.

Further, LESS is now the CSS engine, not SASS. The visual style used, Semantic-UI, is written in LESS, and it makes more sense to write CSS in that language in case there are specific things we need to override. In this case, I still need to manually import the icons to have them work on the frontend.

  • Set up Semantic UI LESS icons to work properly on the frontend

Also fixed Gulp dependency (no longer requires Gulp to be globally installed, points to local Gulp install instead, removed duplicate Gulp dependencies, and moved them all to devDependencies)
@SheaBelsky SheaBelsky changed the title Removes most hardcoded Removes most hardcoded HackMIT references Jul 14, 2018
@SheaBelsky SheaBelsky changed the title Removes most hardcoded HackMIT references Webpack; Removes most hardcoded HackMIT references Jul 15, 2018
@jlin816 jlin816 closed this Jul 25, 2018
@jlin816 jlin816 reopened this Jul 28, 2018
@jlin816
Copy link
Contributor

jlin816 commented Jul 29, 2018

Hi - sorry about closing this earlier, I thought this was one of those commits that people accidentally push here when they're developing for their local hackathon (we get "remove HackMIT" PRs a lot, haha). If you'd still like to contribute to resolving #79, can we split out just the relevant changes for that into a single PR? There are a lot of huge changes rolled into one here.

@SheaBelsky
Copy link
Author

Sure; right now it is indeed the case that it's just pulling from what will become our site. I'll create a separate branch that doesn't have any of our stuff and create another PR with all of the agnostic/general stuff. The only thing I'll leave is the home page route, which might be important to other hackathons.

Resolves #3
Also modified login/registration template to more clearly say that you need a college email.
Resolves #4 and resolves #5
Make sure the user's ID is a string before comparing with a value that we know is a string. Before it was a MongoDB object representing the ID, but it was not 100% a string. Now only a string *should* be able to be compared to determine if the user can see this information.
Colors, application fixes, sponsorship
@jackcook
Copy link
Contributor

I'm going to close this since it seems like you've made a bunch of your own changes that aren't specific to the general Quill repository. We will remove the hardcoded references to HackMIT very soon, thanks for your help!

@jackcook jackcook closed this Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants