This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Add prefer-const rule to tslint #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitko-Kerezov
approved these changes
Aug 25, 2017
galexandrov
approved these changes
Aug 25, 2017
| let urlString = args[0], | ||
| username = args[1], | ||
| password = args[2]; | ||
| let urlString = args[0]; |
There was a problem hiding this comment.
nope, it is set on line 39
Also now linter checks if any const can be used instead of let and shows error in this case.
helpers.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| import * as uuid from "uuid"; | |||
| import * as net from "net"; | |||
| let Table = require("cli-table"); | |||
| const Table = require("cli-table"); | |||
There was a problem hiding this comment.
Can we move the const after the imports, seems more right :)
Enable `prefer-const` rule in tslint and fix the errors: The rule requires that variable declarations use const instead of let and var if possible. If a variable is only assigned to once when it is declared, it should be declared using `const` The prefer-const rule checks the code and verifies the usage of let and const
rosen-vladimirov
force-pushed
the
vladimirov/prefer-const
branch
from
6697c53 to
408e9cd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
prefer-construle in tslint and fix the errors:The rule requires that variable declarations use const instead of let and var if possible.
If a variable is only assigned to once when it is declared, it should be declared using
constThe prefer-const rule checks the code and verifies the usage of let and const