Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

Get iOS simulator by name and sdk #1084

Merged
merged 1 commit into from
Apr 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mobile/ios/simulator/ios-emulator-services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ class IosEmulatorServices implements Mobile.IiOSSimulatorService {
public async startEmulator(emulatorImage?: string): Promise<string> {
return this.$iOSSimResolver.iOSSim.startSimulator({
id: emulatorImage,
state: "None"
state: "None",
sdkVersion: this.$options.sdk
});
}

Expand Down
7 changes: 6 additions & 1 deletion mobile/mobile-core/devices-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,12 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
* @param identifier running emulator or device identifier
*/
public getDeviceByIdentifier(identifier: string): Mobile.IDevice {
const searchedDevice = _.find(this.getDeviceInstances(), (device: Mobile.IDevice) => { return device.deviceInfo.identifier === identifier; });
const searchedDevice = _.find(this.getDeviceInstances(), (device: Mobile.IDevice) => {
if (this.$mobileHelper.isiOSPlatform(device.deviceInfo.platform) && device.isEmulator) {
return device.deviceInfo.identifier === identifier || device.deviceInfo.displayName === identifier;
}
return device.deviceInfo.identifier === identifier;
});
if (!searchedDevice) {
this.$errors.fail(this.$messages.Devices.NotFoundDeviceByIdentifierErrorMessageWithIdentifier, identifier, this.$staticConfig.CLIENT_NAME.toLowerCase());
}
Expand Down