Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

At post-install, ask the user to turn on command line autocompletion #237

Merged
merged 1 commit into from
Mar 18, 2015

Conversation

teobugslayer
Copy link
Contributor


public execute(args: string[]): IFuture<void> {
return (() => {
this.$logger.out("If you are using bash or zsh, you can enable command line auto completion.");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should notify the user that we will write some data in bash_profile, zsh and bashrc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - in the help file

@rosen-vladimirov
Copy link
Collaborator

👍 after considering my suggestion

this.$logger.out("If you are using bash or zsh, you can enable command line auto completion.");
var message = "Enable it now?";

var autoCompetionStatus = this.$prompter.confirm(message, () => "y").wait();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we prompt this message only when we have interactive console?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will restore the code (it used to be there)

@teobugslayer teobugslayer force-pushed the totev/bash-completion-prompt branch from db06294 to c2fd099 Compare March 18, 2015 15:59
@Fatme
Copy link
Contributor

Fatme commented Mar 18, 2015

👍

teobugslayer added a commit that referenced this pull request Mar 18, 2015
At post-install, ask the user to turn on command line autocompletion
@teobugslayer teobugslayer merged commit 5fef4f0 into master Mar 18, 2015
@teobugslayer teobugslayer deleted the totev/bash-completion-prompt branch July 30, 2015 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants