This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Support Google API images in Android Emulator. #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // this might be a google image | ||
| platform = target.split(":")[2]; | ||
| if (platform) { | ||
| platformNumber = +platform; |
There was a problem hiding this comment.
What will happen in case this is some strange image and after splitting by ":" we get string or undefined for platform. +ing it will set platformNumber ot NaN and the code will not work
There was a problem hiding this comment.
Well, if is a strange image, the code won't work anyway. Right now it returns undefined and the map()s after that do not find a suitable image and we give a message "no image found". I can make it throw an exception but this ultimately would give the same message to the user, right?
There was a problem hiding this comment.
Ok, I didn't check the rest of the code, sorry.
|
👍 awesome 😸 |
teobugslayer
added a commit
that referenced
this pull request
Apr 6, 2015
Support Google API images in Android Emulator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See NativeScript/nativescript-cli#175