This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Filter configuration specific files #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
nadyaA
force-pushed
the
natanasova/debug-release-bug
branch
from
c42945d to
6236208
Compare
|
💔 |
nadyaA
force-pushed
the
natanasova/debug-release-bug
branch
from
6236208 to
1868238
Compare
|
💔 |
rosen-vladimirov
suggested changes
Jul 9, 2017
| let directoryPath = temp.mkdirSync("Project Files Manager Tests"); | ||
|
|
||
| _.each(filesToCreate, file => fs.writeFile(path.join(directoryPath, file), "")); | ||
| _.each(filesToCreate, file => createFile(testInjector, file, "", directoryPath)); |
There was a problem hiding this comment.
createFile returns promise, currently noone is awaiting this promise
There was a problem hiding this comment.
I changed the method to return string. Thanks
| return directoryPath; | ||
| } | ||
|
|
||
| async function createFile(testInjector: IInjector, fileToCreate: string, fileContent: string, directoryPath?: string): Promise<string> { |
There was a problem hiding this comment.
this method does not have to be async - it doesn't have any async operations in it
declarations.d.ts
Outdated
| @@ -867,7 +867,7 @@ interface ILiveSyncServiceBase { | |||
| * If watch option is not specified executes full sync | |||
| * If watch option is specified executes partial sync | |||
| */ | |||
| sync(data: ILiveSyncData[], projectId: string, filePaths?: string[]): Promise<void>; | |||
| sync(data: ILiveSyncData[], projectId: string, filePaths: string[], projectFilesConfig: IProjectFilesConfig): Promise<void>; | |||
There was a problem hiding this comment.
Why is this changed? The sync method must have filePaths as optional argument, as they are passed only when we are not in full sync mode
nadyaA
force-pushed
the
natanasova/debug-release-bug
branch
from
1868238 to
a42b05a
Compare
|
💔 |
nadyaA
force-pushed
the
natanasova/debug-release-bug
branch
from
a42b05a to
0667a3a
Compare
|
💔 |
nadyaA
force-pushed
the
natanasova/debug-release-bug
branch
from
0667a3a to
f15dba7
Compare
|
💔 |
|
run ci |
|
💔 |
nadyaA
force-pushed
the
natanasova/debug-release-bug
branch
from
f15dba7 to
661ffff
Compare
|
💔 |
rosen-vladimirov
suggested changes
Jul 13, 2017
helpers.ts
Outdated
| @@ -400,6 +401,13 @@ export async function connectEventuallyUntilTimeout(factory: () => net.Socket, t | |||
| }); | |||
| } | |||
|
|
|||
| export function getProjectFilesConfig(release: boolean): IProjectFilesConfig { | |||
There was a problem hiding this comment.
;( passing boolean property to a method 😿 😢
There was a problem hiding this comment.
you can modify this to be:
export function getProjectFilesConfig(opts: { isReleaseBuild: boolean }): IProjectFilesConfig {
}
TomaNikolov
reviewed
Jul 13, 2017
| @@ -191,11 +199,39 @@ describe("Project Files Manager Tests", () => { | |||
| assert.isTrue(fs.exists(path.join(directoryPath, "a.test"))); | |||
| }); | |||
|
|
|||
| it("filters release specific files", async () => { | |||
| const directoryPath = await createFile(testInjector, "test.debug.x", "debug"); | |||
There was a problem hiding this comment.
Since createFile is no longer async you can remove await
| it("filters release specific files", async () => { | ||
| const directoryPath = await createFile(testInjector, "test.debug.x", "debug"); | ||
| const releaseFileContent = "release"; | ||
| await createFile(testInjector, "test.release.x", releaseFileContent, directoryPath); |
| }); | ||
|
|
||
| it("filters debug specific files by default", async () => { | ||
| const directoryPath = await createFile(testInjector, "test.release.x", "release"); |
| it("filters debug specific files by default", async () => { | ||
| const directoryPath = await createFile(testInjector, "test.release.x", "release"); | ||
| const debugFileContent = "debug"; | ||
| await createFile(testInjector, "test.debug.x", debugFileContent, directoryPath); |
nadyaA
force-pushed
the
natanasova/debug-release-bug
branch
from
661ffff to
25c8cda
Compare
|
💔 |
nadyaA
force-pushed
the
natanasova/debug-release-bug
branch
from
25c8cda to
456b532
Compare
|
💔 |
rosen-vladimirov
approved these changes
Jul 27, 2017
Respect prepare/build configuration when preparing project files.
nadyaA
force-pushed
the
natanasova/debug-release-bug
branch
from
456b532 to
415631c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect prepare/build configuration when preparing project files.
NativeScript/nativescript-cli#2934