Skip to content

Run linux tests before building the wheel. #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 5, 2020
Merged

Run linux tests before building the wheel. #1212

merged 6 commits into from
Mar 5, 2020

Conversation

gabrieldemarmiesse
Copy link
Member

No description provided.

@boring-cyborg boring-cyborg bot added the build label Mar 3, 2020
@boring-cyborg boring-cyborg bot added the github label Mar 3, 2020
seanpmorgan
seanpmorgan requested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Almost LGTM one issue for the failing test and then need to fix conflict.

seanpmorgan
seanpmorgan approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@seanpmorgan seanpmorgan merged commit c59289c into tensorflow:master Mar 5, 2020
@gabrieldemarmiesse gabrieldemarmiesse deleted the run_linux_tests_before_building_wheel branch March 8, 2020 16:30
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@seanpmorgan
Run linux tests before building the wheel. (tensorflow#1212)
566ec32 
* Run linux tests before building the wheel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

Assignees
No one assigned
Labels
build cla: yes github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrieldemarmiesse @seanpmorgan @googlebot