Skip to content

Add AVX2 support #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Add AVX2 support #2299

merged 2 commits into from
Dec 17, 2020

Conversation

seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented Dec 17, 2020

Description

Support AVX2 compilation by default

Fixes #1148

Don't think we need to support anything older than AVX2. Also did some cleanup on our builds

@boring-cyborg boring-cyborg bot added github test-cases Related to Addons tests labels Dec 17, 2020
@google-cla google-cla bot added the cla: yes label Dec 17, 2020
bazel.exe build \
-c opt \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why -c opt is removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's written by default in configure:
https://github.com/tensorflow/addons/blob/master/configure.py#L108

Just wanted to set that as the central source of build args

@WindQAQ WindQAQ self-requested a review December 17, 2020 04:31
Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@WindQAQ WindQAQ merged commit 04aba76 into tensorflow:master Dec 17, 2020
@seanpmorgan seanpmorgan deleted the support-avx2 branch December 17, 2020 04:40
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
* * Add AVX2 during compilation

* * Rm unecessary
@WindQAQ WindQAQ mentioned this pull request Jan 6, 2021
@svobora
Copy link

svobora commented Jan 12, 2021

My i7-3930k and i7-4930k send their regards.

@seanpmorgan
Copy link
Member Author

My i7-3930k and i7-4930k send their regards.

We'll release a 0.12.1 path version in the near future:
#2355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes github test-cases Related to Addons tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable SSE4.2 and AVX support during build
3 participants