-
Notifications
You must be signed in to change notification settings - Fork 614
Add Kendall's Tau-c, Spearman's Rank, Pearson's Correlation metrics #2741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You are owner of some files modified in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good change, but it's very hard to see the diffs - is it possible to either branch the file so that it shows diffs, or separate the renaming of the file from the other edits.
I'm not a frequent github user - if there's an easy way for me to see the diffs that would be helpful.
There is no change per se, the original code remains the same modulo some refactoring. I have factored |
@sorensenjs I changed the commit history to highlight the differences, this is the best I could come up with: b4977f4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. This is a nice generalization.
@nicolaspi Can you PR the codeowners file to match this refactoring? |
Description
Add Kendall's Tau-c, Spearman's Rank, Pearson's Correlation metrics.
Type of change
Checklist:
How Has This Been Tested?
The tests follows the contribution guidelines for metrics (https://github.com/tensorflow/addons/blob/master/tensorflow_addons/metrics/README.md#contribution-guidelines).
The metrics are tested against the scipy implementation counterpart.