Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin maven-install-plugin version to 2.4 #201

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

Eskibear
Copy link
Contributor

required by eclipse-m2e/m2e-core#1238 , as maven-3.9.1 use maven-install-plugin:3.1.0 by default

@HannesWell
Copy link
Contributor

Instead of adjusting the expected version I think it would be better to pin the version in the
org.eclipse.m2e.tests\projects\markers\testBuildContextWithSameProjectConfiguratorTwice\pom.xml. You can just add in the build/plugins section:

      <plugin>
        <artifactId>maven-install-plugin</artifactId>
        <version>2.4</version>
      </plugin> 

This way we don't have to update the test the next time Maven updates the default version for the install plugin.

@Eskibear
Copy link
Contributor Author

Sure, it's definitely better, getting rid of the dependency on maven's default bindings. Let me update it.

@Eskibear Eskibear changed the title Update maven-install-plugin version in MarkerTest Pin maven-install-plugin version to 2.4 Mar 29, 2023
@Eskibear
Copy link
Contributor Author

Updated.

Thank you and have a good day!

Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jenkins build in eclipse-m2e/m2e-core#1238 succeeded and the GitHub workflow does not pick up the latest commit on top of the set up branch automatically but considers the sub-module pointer.
So this is fine as expected.

Thank you for this contribution.

@HannesWell HannesWell merged commit c28a3a1 into tesla:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants