Skip to content

implement rerender #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 3, 2018
Merged

implement rerender #70

merged 5 commits into from
May 3, 2018

Conversation

johann-sonntagbauer
Copy link
Collaborator

What:
Implement rerender callback in render result object.

Why:
As already discussed in #65

How:
Provide rerender callback in render result object.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

kentcdodds
kentcdodds approved these changes May 3, 2018
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few small changes. This looks great. Thank you so much for your help @johann-sonntagbauer!

@kentcdodds kentcdodds merged commit 263aabd into testing-library:master May 3, 2018
@johann-sonntagbauer
Copy link
Collaborator Author

@kentcdodds thx for the opportunity. Was a great experience and I learned a lot.

@kentcdodds
Copy link
Member

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kentcdodds
Copy link
Member

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@johann-sonntagbauer johann-sonntagbauer deleted the pr/rerender branch May 3, 2018 18:31
julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
@gnapse
fix: remove extend-expect (testing-library#70)
7f99fb8 
* Use extend-expect directly from jest-dom

* Move jest-dom to devDependencies

BREAKING CHANGE: dom-testing-library no longer exposes the extend-expect module. Replace anywhere you're using `'dom-testing-library/extend-expect'` with `'jest-dom/extend-expect'` 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johann-sonntagbauer @kentcdodds