Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: advanced-select - search bar background not correct with themes. #57

Open
IlGalvo opened this issue Feb 12, 2025 · 4 comments · May be fixed by #58
Open

bug: advanced-select - search bar background not correct with themes. #57

IlGalvo opened this issue Feb 12, 2025 · 4 comments · May be fixed by #58

Comments

@IlGalvo
Copy link

IlGalvo commented Feb 12, 2025

What version of FlyonUI are you using?

v1.3.0

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

Describe your issue

The bug can be found in:

File: https://github.com/themeselection/flyonui/blob/main/src/js/plugins/select/index.ts
Line: 167
Code: this.searchWrapperClasses = concatOptions?.searchWrapperClasses || 'bg-white p-2 sticky top-0'

Bug: bg-white
Fix: bg-base-100

As you cane see in the pic below:

Light theme=> Correct (always white):
Image

Dark theme=> Incorrect (still white):
Image

Copy link

Hi @IlGalvo

Thank you for your support in helping us improve FlyonUI!

We’ve received your submission and will respond within few business days. Our team handles issues one at a time, and we’ll be reviewing yours as soon as possible.

In the meantime, any additional details or a reproducible example would be greatly appreciated and will help us resolve the issue more efficiently.

Thank you for your patience and understanding!

IlGalvo added a commit to IlGalvo/flyonui that referenced this issue Feb 12, 2025
@IlGalvo IlGalvo linked a pull request Feb 12, 2025 that will close this issue
@yagnikvamja
Copy link
Member

Hello @IlGalvo ,

Thank you for your valuable contribution! We sincerely appreciate the time and effort you have put into your pull request.

Upon review, we noticed a minor update that needs to be addressed to ensure consistency and completeness. Specifically, we kindly ask you to update the following line to: 'bg-base-100 sticky top-0 mb-2 px-2 pt-3'

This adjustment aligns with the default style specified in the Options Table, as documented here: Advanced Select - Search Options. We appreciate your assistance in implementing this correction.

Additionally, as our team is currently working on FlyonUI with TailwindCSS 4, the merging process may take some time, and the update will be included in an upcoming release. In the meantime, we recommend using searchWrapperClasses and updating it as shown below to ensure proper functionality:

<select
  data-select='{
    "placeholder": "Select your sign",
    ...
    "searchWrapperClasses": "bg-base-100 sticky top-0 mb-2 px-2 pt-3"
  }'
  class="hidden"
>
</select>

We truly appreciate your patience and support. Thank you once again for your contribution!

~Best regards,

@IlGalvo
Copy link
Author

IlGalvo commented Feb 12, 2025

Hi @yagnikvamja,

I proceeded to make the requested change:
#58

It should be ok now, let me know if you need anything else.
Thanks for the suggestion about the temporary workaround.

Keep it up!

@OmkarOza
Copy link
Member

Hello @IlGalvo,

We truly appreciate your valuable feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants