-
Notifications
You must be signed in to change notification settings - Fork 278
Add root metadata class to new TUF metadata model #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See: Add root metadata class to new TUF metadata model theupdateframework#1137 Add classes for complex metadata fields theupdateframework#1139 Add input validation to simple metadata api theupdateframework#1140 Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
See: Add root metadata class to new TUF metadata model theupdateframework#1137 Add classes for complex metadata fields theupdateframework#1139 Add input validation to simple metadata api theupdateframework#1140 Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Apologies if I had ruined someone's first issue but I needed this so I opened #1193 😁 I want to mention that in the tests I had to fix dictionaries passed by reference and afterwards used as expected updated values.
I think we should design the metadata classes in a way that discourages such usage. |
Good catch, thanks! That does seem like another good argument for using classes for metadata fields, rather than passing dicts around. |
fat-fingered the wrong button 🤦 |
Description of issue or feature request:
Add root metadata class to
tuf.api.metadata
module and implement (de)serialisation methods (to_dict
andfrom_dict
) and adequate metadata update methods (seetuf.api.Signed
-subclasses for inspiration).Current behavior:
No Root class in
tuf.api.metadata
Expected behavior:
The text was updated successfully, but these errors were encountered: