Add .gitattributes file #1321
Merged
Add .gitattributes file #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with Windows systems, declare repository_data files to always have LF line endings on checkout. A trailing "/**" matches everything inside, with infinite depth. Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
joshuagl
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Thank you for the PR @sechkova! Great to have this fixed for folks running the tests on Windows.
NOTE: anyone running on windows with an existing checkout will need to run git reset to ensure the EOL sequence is updated for files that have already been created:
git reset --hard
I tested this by:
- cloning the tuf repo on Windows, seeing the EOL sequence of tests/repository_data/repository/metadata/root.json is CRLF
- cloning your tuf fork (and gitattr branch) on Windows, seeing the EOL sequence of tests/repository_data/repository/metadata/root.json is LF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
For compatibility with Windows systems, declare repository_data files to always have LF line endings on checkout.
The pattern
tests/repository_data/**matches everything inside the directorytests/repository_datarelative to the.gitattributesfile, with infinite depth.Please verify and check that the pull request fulfills the following
requirements: