Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAThreadExecutorAttribute, CultureAttribute and abstract DedicatedThreadExecutor #2156

Merged
merged 6 commits into from
Mar 26, 2025

Conversation

thomhurst
Copy link
Owner

No description provided.

{
var tcs = new TaskCompletionSource<object?>();

var thread = new Thread(async void () =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should stay with non-async valueTask.AsTask.GetResult() see https://stackoverflow.com/a/78936077/1220972

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good shout

@thomhurst thomhurst disabled auto-merge March 26, 2025 10:12
@thomhurst thomhurst merged commit f7cf8c7 into main Mar 26, 2025
7 of 8 checks passed
@thomhurst thomhurst deleted the feature/dedicated-thread-executor branch March 26, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants