remove dangerous arithmetic feature #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heh maybe a less mysterious warning is better.. "Can't do arithmetic on control pattern." ? |
gillespi314
added a commit
to gillespi314/strudel
that referenced
this pull request
Jan 3, 2025
Revises outdated documentation in light of PR tidalcycles#1030
yaxu
pushed a commit
that referenced
this pull request
Jan 12, 2025
Revises outdated documentation in light of PR #1030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1026
currently just logs
[warn]: dangerous arithmeticwhen something liken(1).add(1)is attempted.Or maybe remove the log?