Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tutorial + custom samples doc #1053

Merged
merged 8 commits into from
Apr 12, 2024
Merged

improve tutorial + custom samples doc #1053

merged 8 commits into from
Apr 12, 2024

Conversation

felixroos
Copy link
Collaborator

@felixroos felixroos commented Apr 11, 2024

  • add drum image
  • introduce <...> earlier, because it's weird to introduce cpm as the only way to make a regular sequence slower.
  • I've also tried to replace .cpm with setcps for changing tempo but it seems the mini repl does some strange things sometimes with setcps so i've kept it for now.
  • update custom samples section with new stuff (import sounds, sampler etc)

- add drumset image
- introduce angle brackets earlier
@felixroos felixroos changed the title Workshop edits Tutorial edits Apr 11, 2024
@yaxu
Copy link
Member

yaxu commented Apr 11, 2024

Yep I think .cpm is a bit confusing and it'd be better not included in the tutorial, and maybe deprecated.

@felixroos
Copy link
Collaborator Author

Yep I think .cpm is a bit confusing and it'd be better not included in the tutorial, and maybe deprecated.

I think it might still be good to introduce setcpm, because the number range is more spaced out compared to setcps + it's easier to translate to bpm

- strudel.json
- github shortcut
- "import sounds"
- @strudel/sampler
- improve structure
- add drumset
@felixroos felixroos changed the title Tutorial edits improve tutorial + custom samples doc Apr 12, 2024
@felixroos felixroos merged commit e0c4997 into main Apr 12, 2024
2 checks passed
@felixroos felixroos deleted the workshop-edits branch April 12, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants