-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change fanchor to 0 #1107
change fanchor to 0 #1107
Conversation
daslyfe
commented
May 19, 2024
•
edited
Loading
edited
- kinda breaking change: will change patterns without the fanchor set using fenv to be a bit brighter
- It's time to make this change, it is a source of confusion when giving workshops why the filter env behaves in a bipolar fashion by default. Imagine strumming an instrument harder, and the harmonics fading faster. Bipolar envelopes can also cause clicks if the cutoff dips too low.
Agreed that 0 is a better default! |
Cool sounds good :) I added the setDefault function. Im not sure how to go through the db and modify existing patterns though to add the old default |
git push
looks good, thanks for adding! I think the last thing missing is something like |
What if we had a version tag at the top of the editor? like // @ver 2.15 |
and no version tag would mean the old defaults are used? not sure if it's good to make the thing we want to standardize opt-in, rather than opt out.. kind of related: #998 (comment) |
continuing now here, because discord is too ephemeral: yep opt-out would also work with the version tag.. so if no version tag is present, use current defaults. if there is one, then use the defaults for that version. |
} | ||
export function setVersionDefaults(version) { | ||
resetDefaultValues(); | ||
if (version === '1.0') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe like this? we might move this to core later as it could be useful for more general feature flagging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this makes sense to me 💯
fixes #1055 |
I'm guessing that you want to do the DB operation for adding the version tag before committing this? |
ok, merging now then quickly running the db update when it's deployed |
db fix is out, i've added // @Version 1.0 to the bottom of each pattern in the db. personal patterns might still be off, so I guess we can mention that in the changelog for 1.1 that you can add the version tag to get the og version |