-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move stuff to new register function #295
Conversation
refactoring is mostly done, removed all all old define calls + stuff that is no longer needed. Had to rename |
after looking at the failed snapshot tests, I think it's safe to overwrite the snaps. There are 3 reasons why things changed:
1 seems to be normal with the new register function. it already happened in #286 2 looks like the old data had wrong octaves the whole time. I listened to all the failing examples / tunes, they sound exactly the same as before 3 comes from the fact that the mini notation had a stateful handling of random values. I would remove that behavior, as it is undeterministic and leads to bugs, e.g. #245 |
Tidal has a 'defragment' function that combines adjacent parts with the same whole and value. Along with Just having a go at porting defragment.. |
do you plan to add it to this PR or should we merge this one first? |
I can do it as a separate PR |
getting rid of all usages of
Pattern.prototype.define
,Pattern.prototype.bootstrap
,Pattern.patternify
,patternifyN