Skip to content

Downstream packages that use stat_contour() need to add isoband to Suggests #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paleolimbot opened this issue Oct 10, 2019 · 5 comments · Fixed by #3598
Closed

Downstream packages that use stat_contour() need to add isoband to Suggests #3564

paleolimbot opened this issue Oct 10, 2019 · 5 comments · Fixed by #3598

Comments

@paleolimbot
Copy link
Member

Just a note from going through these revdeps that several packages fail as a result of needing the isoband package, which is used for stat_contour() and friends. This is new after #3439.

Packages that fail are bayesAB, fgeo.plot, and gganimate.

@paleolimbot paleolimbot changed the title Downstream packages that use stat_contour() need to ass isoband to Suggests Downstream packages that use stat_contour() need to add isoband to Suggests Oct 10, 2019
@clauswilke
Copy link
Member

Should we list isoband under Imports? I would think of making contour plots as a basic feature that should work out of the box after installing ggplot2. Similarly, we also import mgcv.

The isoband package does not pull in any additional dependencies, as I designed it specifically that way. It only depends on Rcpp, grid, and utils, which are already either direct or indirect dependencies of ggplot2.

@thomasp85
Copy link
Member

If we rely on it for something that were dependency free before I think we need to import it to avoid breaking code

@yutannihilation
Copy link
Member

+1 for adding isoband to Imports.

@paleolimbot
Copy link
Member Author

I agree...I was waiting for the last PR I did to get reviewed before starting a new one, but could easily tackle this one later today.

@lock
Copy link

lock bot commented May 5, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants