-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Downstream packages that use stat_contour()
need to add isoband to Suggests
#3564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
stat_contour()
need to ass isoband to Suggestsstat_contour()
need to add isoband to Suggests
Should we list isoband under The isoband package does not pull in any additional dependencies, as I designed it specifically that way. It only depends on Rcpp, grid, and utils, which are already either direct or indirect dependencies of ggplot2. |
If we rely on it for something that were dependency free before I think we need to import it to avoid breaking code |
+1 for adding isoband to Imports. |
I agree...I was waiting for the last PR I did to get reviewed before starting a new one, but could easily tackle this one later today. |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Just a note from going through these revdeps that several packages fail as a result of needing the isoband package, which is used for
stat_contour()
and friends. This is new after #3439.Packages that fail are bayesAB, fgeo.plot, and gganimate.
The text was updated successfully, but these errors were encountered: