Skip to content

Fix tick misalignment with secondary axes (#2978) #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix tick misalignment with secondary axes (#2978) #3004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6fe5cf5
add rescaling to secondary axis
dpseidel Nov 14, 2018
0c258c8
update vdiffr svgs
dpseidel Nov 14, 2018
e211ffe
add positioning and visual tests for sec.axis
dpseidel Nov 15, 2018
b7ac60c
use data_frame() in tests
dpseidel Nov 15, 2018
c036488
Merge remote-tracking branch 'upstream/master' into sec_scale
dpseidel Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions R/axis-secondary.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,10 @@ AxisSecondary <- ggproto("AxisSecondary", NULL,
if (self$empty()) return()

# Get original range before transformation
inv_range <- scale$trans$inverse(range)
along_range <- seq(range[1], range[2], length.out = self$detail)
old_range <- scale$trans$inverse(along_range)

# Create mapping between primary and secondary range
old_range <- seq(inv_range[1], inv_range[2], length.out = self$detail)
full_range <- self$transform_range(old_range)

# Test for monotonicity
Expand All @@ -165,7 +165,12 @@ AxisSecondary <- ggproto("AxisSecondary", NULL,
# Get break info for the secondary axis
new_range <- range(scale$transform(full_range), na.rm = TRUE)
sec_scale <- self$create_scale(new_range, scale)

range_info <- sec_scale$break_info()
old_val <- old_range[unlist(lapply(range_info$major_source, function(x) which.min(abs(scale$trans$transform(full_range) - x))))]
old_val_trans <- scale$trans$transform(old_val)
range_info$major[] <- round(rescale(scale$map(old_val_trans, range(old_val_trans)), from = range), digits = 3)

names(range_info) <- paste0("sec.", names(range_info))
range_info
},
Expand Down
Loading