Skip to content

Upgrade to roxygen2 7.0.1 #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2019
Merged

Upgrade to roxygen2 7.0.1 #3637

merged 2 commits into from
Nov 24, 2019

Conversation

hadley
Copy link
Member

@hadley hadley commented Nov 23, 2019

Including converting all uses of \% back to %, and removing roxygen2 tags that the new warnings indicated were superfluous.

Including converting all uses of `\%` back to `%`, and removing roxygen2 tags that the new warnings indicated were superfluous.
Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have no idea why Travis fails...

@hadley
Copy link
Member Author

hadley commented Nov 24, 2019

Hmmm that's a little concerning. @thomasp85 can you please take a look? 3 unit tests are failing but only for R-release on linux

@yutannihilation
Copy link
Member

yutannihilation commented Nov 24, 2019

All the failing tests are visual ones. I think we can just update the visual cases, but I don't know well about the details of the latest release of scales package, so could you confirm this is expected? I created another PR to fix this: #3638

In any case, I bet updating roxygen2 is irrelevant to the failures.

@clauswilke
Copy link
Member

The scales package changed the code used to calculate color ramps (see here: r-lib/scales@eb24db7). As a result, I would expect all visual tests with color ramps to fail. I would recommend visually checking that the new color ramps look fine and then accepting the new test cases.

@yutannihilation
Copy link
Member

Oh, thanks for identifying the commit.

I would recommend visually checking that the new color ramps look fine

Yes, I've checked on my local. I'll post the comparison on #3638.

@hadley
Copy link
Member Author

hadley commented Nov 24, 2019

Thanks all! I've merged the latest master into this branch so hopefully the next round of checks will pass.

@hadley hadley merged commit 5dfe498 into master Nov 24, 2019
@hadley hadley deleted the roxygen2-7.0.1 branch November 24, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants