-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fixes #4399 #4823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4399 #4823
Conversation
Ah, I think you saw this kind of warning. You need to install the packages to generate the proper links. Typically this can be done by
But, I believe |
Clearer documentation indicating that fullrange may extend beyond the data but does not fill the area created by expansion. Docs regenerated by devtools::document() did create some warnings that are unrelated to these changes. Presumably known issues?
Thanks for the help, @yutannihilation. I updated Hmisc and the pull request to not include those changes. All tests have passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, but let me add some nitpicky comments.
- Could you add
`
aroundTRUE
? - Using the word
fullrange
in the description offullrange
feels a bit redundant to me. What about the form of "is expanded?" (Sorry, I'm not very fluent in English, so I might be wrong here)
wording change Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com>
I committed the changes, but need to regenerate docs, will push an update and then it should be good |
Docs regenerated, tests passed |
Thanks! |
Clearer documentation indicating that fullrange may extend beyond the data but does not fill the area created by expansion.
Docs regenerated by devtools::document() did create some warnings that are unrelated to these changes. Presumably known issues?