Roll back updates to update_geom/stat_defaults()
#5837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
changed the title
update_geom/stat_defaults()
|
We need this to be a PR against main with the new release structure |
This reverts commit 60407ac.
teunbrand
force-pushed
the
revert_updaters
branch
from
b4cb81d to
7265e93
Compare
|
Thanks for that pointer! I used |
thomasp85
reviewed
Apr 18, 2024
|
I revived the relevant issue #4993. I think I cannot make a new PR from main until the rollback is complete. |
thomasp85
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #5781 in the prep/3.5.1 branch.
Briefly, #5781 was giving some grief with reverse dependencies so this PR allows us to postpone #5781 to a later release.