feat: add lanelet bounds loader #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Assets/AWSIM/Scripts/Editor/RandomTraffic/Environments/LaneletLoader/LaneletBoundsLoader.cs
Outdated
Show resolved
Hide resolved
Assets/AWSIM/Scripts/Editor/RandomTraffic/Environments/LaneletLoader/LaneletBoundsLoader.cs
Outdated
Show resolved
Hide resolved
Assets/AWSIM/Scripts/Editor/RandomTraffic/Environments/LaneletLoader/LaneletBoundsLoader.cs
Outdated
Show resolved
Hide resolved
mackierx111
requested changes
May 18, 2023
There was a problem hiding this comment.
Please clarify the purpose of this implementation. If visualization of lanelets is your only goal, keep the following in mind.
- Traffic lane class is used for NPC travel routes in random traffic. It would be inappropriate for lanelet visualization.
- If the amount of information is reduced by Resolution or other means when the lanelet is loaded, accurate visualization of the lanelet will not be possible.
- If you want to visualize lanelets more precisely, traffic lights and signs could also be targets.
...s/AWSIM/Scripts/Editor/RandomTraffic/Environments/LaneletLoader/LaneletBoundsLoaderWindow.cs
Outdated
Show resolved
Hide resolved
Assets/AWSIM/Scripts/Editor/RandomTraffic/Environments/LaneletLoader/LaneletBoundsLoader.cs
Outdated
Show resolved
Hide resolved
|
@mackierx111 |
tyongingo
pushed a commit
to tyongingo/AWSIM
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Alptuğ Cırıt <alptug@leodrive.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a Unity Editor extension which allows the user to load the left and right sides of the Lanelet.
The original "Load Lanelet" extension is kept unchanged so the user can optionally choose to use the new extension "Load Lanelet Bound" if they wish to load the sides of the Lanelet instead of the centerlines.
Tests performed
The feature has been tested using AWSIM.
Lanelet without the sides (only Centerlines and StopLines)
Lanelet with the sides
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.