feat: smoke simulator #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is an image of the smoke simulator compared with particle system. The particles of the smoke simulator is detected by the LiDAR.
|
mackierx111
requested changes
Jun 14, 2023
There was a problem hiding this comment.
Thank you for the implementation. Some feedback.
- Please move the
SmokeGeneratorscript directory underEnvironments.Assets\AWSIM\Scripts\Environments\SmokeGenerator
- Please create a SmokeGenerator prefab.
- Could you add a comment for the public attribute member or class of each script? (Not necessary for those that have comments written in Tooltip)
tyongingo
pushed a commit
to tyongingo/AWSIM
that referenced
this pull request
Nov 22, 2024
Signed-off-by: A. Sena Yılmaz <aysena@leodrive.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating a smoke simulator such that the RGL LiDAR will be able to detect the particles of the smoke.
To the best of my knowledge, this cannot be done with Particle System, so there is a need to create a new feature for achieving the task.
The feature is still under development and needs further adjustment.
