Skip to content

Feature/rgl regression restriction #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PiotrMrozik
Copy link
Contributor

No description provided.

Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
Copy link
Contributor

@PawelLiberadzki PawelLiberadzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please be sure that all this object metadata was added there intentionally, in other word, these object are necessary / useful.


private void OnNewLidarData()
{
int pointCount = rglSubgraphYieldOutput.GetResultData<Vector3>(ref onlyHits);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable seems to be not used at all.

@PawelLiberadzki PawelLiberadzki merged commit 80ee555 into feature/rgl-q2-features Jun 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants