Skip to content

Fix(prefab): Lexus top velodyne orientation and frame naming #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

kielczykowski-rai
Copy link
Contributor

@kielczykowski-rai kielczykowski-rai commented Jul 30, 2024

I noticed that the Lexus URDF tree is slightly different from what is expected on the Autoware sensor calibration files.

  1. The VelodyneVLP16 GameObject was placed straight under sensor_kit_base_link instead of velodyne_top_base_link GameObject as other sensors in the Prefab.
  2. The top velodyne lidar was missing the proper yaw orientation setting.
  3. The velodyne_*_base_link naming seems to be obsolete in Autoware (example1, example2). Currently, all the frames are named velodyne_top, velodyne_right and velodyne_left

image

The proposed PR fixes the mentioned errors. State after fix can be seen in the image below

image

Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mackierx111 mackierx111 merged commit acffcba into main Aug 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants