-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang noobs installation tutorial #36
base: master
Are you sure you want to change the base?
Conversation
@@ -5,7 +5,18 @@ | |||
node-prune is a small tool to prune unnecessary files from ./node_modules, such as markdown, typescript source files, and so on. Primarily built for [Up](https://github.com/apex/up) which lets you deploy serverless web applications in seconds. | |||
|
|||
## Installation | |||
If Go is already installed check check if your are using latest version, comparing to https://github.com/golang/go/releases, type this command to check your local Go version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: you are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two instances of check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would lean on pointing to the golang
docs on how to install and update your package instead of trying to maintain it here. At some point its going to be out of sync!
``` | ||
$ go version | ||
``` | ||
Before install package make sure your GOPATH in` ~/.bash_profile` is set. It must be path to Go binaries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it shell-agnostic. Not everyone uses bash
. Also don't forget Windows users, albeit the installer for Go on Windows should add Go to the PATH
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before installing [the] package.
This PR could do with some general improvements in sentence structure, but that's up to @tj. 🚶 |
Expanded installation explanation