Remove openssl from qos_attest #156
Conversation
| @@ -1,17 +1,22 @@ | |||
| //! Logic for decoding and validating the Nitro Secure Module Attestation | |||
| //! Document. | |||
|
|
|||
| use aws_nitro_enclaves_cose::CoseSign1; | |||
| use aws_nitro_enclaves_cose::{ | |||
| crypto::{Hash, MessageDigest, SignatureAlgorithm, SigningPublicKey}, | |||
There was a problem hiding this comment.
Note that SigningPublicKey is a trait we implement to allow us to use an arbitrary public key to verify signatures against for the COSE Sign1 crate.
| .map_err(|e| CoseError::SignatureError(Box::new(e))) | ||
| } | ||
| } | ||
| impl SigningPublicKey for P384PrivateKey { |
There was a problem hiding this comment.
In case this is confusing, SigningPrivateKey is a super trait of SigningPublicKey, so we need to implement both for the private key to get things to compile
| use aws_nitro_enclaves_nsm_api::api::AttestationDoc; | ||
| use p384::{ | ||
| ecdsa::{signature::hazmat::PrehashVerifier, Signature, VerifyingKey}, |
There was a problem hiding this comment.
hazmat is very ominous... should we be worried about this??
There was a problem hiding this comment.
Basically a warning that these are low-level API's that should only be used by experts: https://docs.rs/ecdsa/0.11.1/ecdsa/hazmat/index.html
| fn get_parameters( | ||
| &self, | ||
| ) -> Result<(SignatureAlgorithm, MessageDigest), CoseError> { | ||
| Ok((SignatureAlgorithm::ES384, MessageDigest::Sha384)) |
There was a problem hiding this comment.
Have you done any research to know that this will always be the case?
There was a problem hiding this comment.
Don't have research other then talking to Lance and knowing this it what works with all the attestation docs we have gotten. Important to note that verification will fail if it is signed with a different type of key so its not really a security issue but more of a liveliness issue if this ever changes
No description provided.