handleGoogleOAuth for sdk-react-native #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
moeodeh3
commented
Apr 10, 2025
| @@ -7,3 +7,4 @@ export enum StorageKeys { | |||
|
|
|||
| export const OTP_AUTH_DEFAULT_EXPIRATION_SECONDS = 15 * 60; | |||
| export const MAX_SESSIONS = 15; | |||
| export const TURNKEY_OAUTH_PROXY_URL = "http://localhost:3000"; // TODO: WE NEED TO CHANGE THIS WHEN WE DEPLOY THE PROXY | |||
There was a problem hiding this comment.
need to update this before we merge
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 485de7e:
|
moeodeh3
changed the title
moeodeh3
commented
Apr 10, 2025
| ### **Transaction Signing** | ||
|
|
||
| - `signRawPayload({ signWith, payload, encoding, hashFunction })`: Signs a payload. [(API Docs)](https://docs.turnkey.com/api#tag/Signing/operation/SignRawPayload) | ||
|
|
||
| --- | ||
|
|
||
| ### **OAuth** | ||
|
|
||
| - `handleGoogleOAuth({ clientId, redirectUri, nonce, scheme, onIdToken })`: Handles the Google OAuth authentication flow. |
There was a problem hiding this comment.
we should probably have in our docs a page explaining how to set this up and how this works. Then we can update with a docs link here
amircheikh
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.