Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CI for webdriver tests #1343

Merged
merged 32 commits into from
May 12, 2023
Merged

Adds CI for webdriver tests #1343

merged 32 commits into from
May 12, 2023

Conversation

orangemug
Copy link
Contributor

@orangemug orangemug commented May 9, 2023

Github action CI workflows added for webdriver tests.

I've also refactored the ./scripts/e2e-* scripts. These scripts were somewhat unique compared to the other scripts. They are now more inline with the other scripts in that directory and run via

% yarn e2e --help                               
Usage: yarn e2e <command> [options]

Commands:
  yarn e2e serve              start test server
  yarn e2e test:ci [env]      runner for CI (github-actions)
  yarn e2e test:local         run webdriver tests locally
  yarn e2e test:browserstack  run webdriver tests on browserstack
  yarn e2e selenium:grid      start selenium grid (test linux)

Options:
  --help     Show help                                                 [boolean]
  --version  Show version number                                       [boolean]

I've also added an experimental linux runner see

tldraw/e2e/README.md

Lines 320 to 333 in 2cca4dd

## Experimental
You can now also run _linux_ tests on _macos_. To do this start up a selenium grid with. Note, you **must** have `docker` installed locally.
```sh
yarn e2e selenium:grid
```
Then run
```sh
yarn e2e test:local --os linux -b firefox
```
**Note**: Currently only `firefox` is supported. You can hit <http://localhost:7900/?autoconnect=1&resize=scale&password=secret> to see a VNC of the app runing in a docker container.

Change Type

  • tests — Changes to any testing-related code only (will not publish a new version)

Release Notes

  • Github action CI workflows added for webdriver tests
  • Refactored e2e test runner

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview May 12, 2023 3:25pm
tldraw-docs-staging ✅ Ready (Inspect) Visit Preview May 12, 2023 3:25pm

@orangemug
Copy link
Contributor Author

Blocked on: Missing keys for BROWSERSTACK_USER and BROWSERSTACK_KEY these need to be added to the github-actions secrets.

@orangemug orangemug enabled auto-merge May 12, 2023 15:25
@orangemug orangemug added this pull request to the merge queue May 12, 2023
Merged via the queue into main with commit 545e421 May 12, 2023
@orangemug orangemug deleted the feature/ci-and-improved-output branch May 12, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants