[fix] Sticky text content / hovered shapes #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
…eometry hit area (#4237) This took a while 😵💫 I tried many approaches. The bug is this and fairly specific: - when shape is selected - double-clicking _within_ the label geometry - the text field is selected/focused on the first click, but then it loses the focus on the second click This really showed up in the retro when dragging sticky notes around and then trying to edit them. (but it also applies to other geo shapes) This only happens within the label geometry b/c of the extra logic we do around that. The problem is that the label geometry is actually not the geometry of the actual `<textarea>` and so our logic is sort of at odds with what we're actually rendering. I tried first making the textarea larger with CSS to match the label geometry but this has a lot of downstream side-effects and was a bad idea. The other thing I was trying was some special dbl-click logic but that was also not working as intended. Finally, I noticed that the canvas "loop" code that we have that feeds the click back into the state machine was one of the differentiators when following the code paths. Removing this fixes the issue and doesn't seem to have any other side effects. I spelunked and checked on what the previous PRs for this code and it looks like it'll be fine. This logic has been reworked enough where we don't need it anymore: - #1808 - #1806 This is a followup after this focus PR: #3718 Before: https://github.com/user-attachments/assets/102ea9ca-9b11-4f36-973d-6cd6f9381d3d After: https://github.com/user-attachments/assets/40e575d8-3c1d-427e-b34f-2a30c7911c00 ### Change type - [x] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [ ] `other` ### Release notes - Text editing: fix dbl-click to edit text, when shape is selected, in label geometry hit area
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the UX around sticky notes. It fixes were some bugs related to the editing / hovered shape after cloning a sticky note shape.
Change Type
patch— Bug fixTest Plan