Add BNS support when setting rewards address #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally, working. This makes it more convenient for people with BNS (.ban) domains to login (no longer need to copy paste address from somewhere, which is especially inconvenient from other devices).
I tried to get it to work with the rollup thing, and make
banani-bns
a NPM dependency but couldn't get it working (sorry). Instead, added a script (bns.js
) that sets the library on thewindow.bns
property. Thebns.js
script is miniified, but can be reproduced by doing:Then checking the
bns-browser.js
file.I wasn't sure what RPC to use, so it uses the kalium RPC for now, but can be changed easily.
Also edited the developer docs.
How to test
nishina247.mictest
.ban_1o7ija3mdbmpzt8qfnck583tn99fiupgbyzxtbk5h4g6j57a7rawge6yzxqp
), and the next step will use that addressSuccess