Skip to content

[$40]Add Legacy ID to Challenge Details #4658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rootelement opened this issue Jul 20, 2020 · 9 comments
Closed

[$40]Add Legacy ID to Challenge Details #4658

rootelement opened this issue Jul 20, 2020 · 9 comments
Assignees
@cagdas001
Labels
Beta Env Environment CF Retested Challenge Details Screen Must-fix-before-v5-release P0 Critical (resolve within 4 hours) QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid v5-intgration-sub-code

Comments

@rootelement
Copy link
Contributor

Is your feature request related to a problem? Please describe.
After v5 release to prod, to faciliate report requests, add the challenge legacy id to the bottom of the challenge details page right column

Describe the solution you'd like
Add the legacy id here:
Screen Shot 2020-07-20 at 10 23 30 AM

It should be very light gray, bottom right corner justified, in the format ID: 300xxxxx
@sushilshinde
Copy link
Collaborator

sushilshinde commented Jul 21, 2020 •
edited
Loading

Option 1 :

image

Option 2:

image

@rootelement
Copy link
Contributor Author

I vote section option. First option looks "hackable", like they're seeing something they shouldn't.

@Oanh-and-only-Oanh
Copy link

I prefer option #2

@sushilshinde sushilshinde changed the title Add Legacy ID to Challenge Details [$40]Add Legacy ID to Challenge Details Jul 21, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30133807 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jul 21, 2020 •
edited
Loading

Impliment option 2:

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

run npm run test before PR

@cagdas001 cagdas001 self-assigned this Jul 21, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30133807 has been updated - it has been assigned to cagdas001.

This is an automated message for crazyk via Topcoder X

@cagdas001
Copy link
Collaborator

There are so many failing tests, most of them are not even related to the changed parts. I think those tests were already failing even with the original code base. I'll compare the number of failing tests between the original code base and my local code base. If they're same, I'll just push the changes.

cc @rootelement @Oanh-and-only-Oanh @sushilshinde

cagdas001 added a commit to cagdas001/community-app that referenced this issue Jul 21, 2020
@cagdas001
feat(challenge-detail): add legacy challenge id
93674aa 
Add legacy challenge id at the bottom right corner of the
challenge-detail/Specification/SideBar component.

Addresses topcoder-platform#4658
@cagdas001 cagdas001 mentioned this issue Jul 21, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

verified on beta
Screenshot 2020-07-22 at 7 34 31 PM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30133807

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagdas001 cagdas001

Labels
Beta Env Environment CF Retested Challenge Details Screen Must-fix-before-v5-release P0 Critical (resolve within 4 hours) QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid v5-intgration-sub-code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sushilshinde @rootelement @cagdas001 @crazyk07 @Oanh-and-only-Oanh @lakshmiathreya @SathyaJayabal