-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use project section #1885
Conversation
CodSpeed Performance ReportMerging #1885 will not alter performanceComparing Summary
|
Pull Request Test Coverage Report for Build 13631298998Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it solve the issue with poetry>=2?
Hey @waketzheng! I think it would be great to get it in the 0.24.2. I tested it with both poetry==1.8.5 and poetry==2.1 and left a few comments, please have a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Should we release 0.24.2? Can you do it or do you want me to do it?
I am happy if you do that
Sent from Phone
…---Original---
From: ***@***.***>
Date: Mon, Mar 3, 2025 21:58 PM
To: ***@***.***>;
Cc: "Waket ***@***.******@***.***>;
Subject: Re: [tortoise/tortoise-orm] chore: use project section (PR #1885)
@henadzit approved this pull request.
Looks good to me!
Should we release 0.24.2? Can you do it or do you want me to do it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Description
Use the standard
[project]
section, and move dependencies from[tool.poetry.dependencies]
section toproject.dependencies
.Motivation and Context
Fixes #1898
How Has This Been Tested?
make ci
Checklist: