Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use project section #1885

Merged
merged 18 commits into from
Mar 3, 2025
Merged

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Feb 15, 2025

Description

Use the standard [project] section, and move dependencies from [tool.poetry.dependencies] section to project.dependencies.

Motivation and Context

Fixes #1898

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codspeed-hq bot commented Feb 15, 2025

CodSpeed Performance Report

Merging #1885 will not alter performance

Comparing waketzheng:add-project-section (8b5997d) with develop (d8aeb1e)

Summary

✅ 16 untouched benchmarks

@coveralls
Copy link

coveralls commented Feb 15, 2025

Pull Request Test Coverage Report for Build 13631298998

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.441%

Files with Coverage Reduction New Missed Lines %
tortoise/backends/base/schema_generator.py 2 95.25%
tortoise/fields/relational.py 4 92.66%
Totals Coverage Status
Change from base Build 13496646441: 0.02%
Covered Lines: 6595
Relevant Lines: 7194

💛 - Coveralls

Copy link
Contributor

@henadzit henadzit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it solve the issue with poetry>=2?

@henadzit
Copy link
Contributor

Hey @waketzheng! I think it would be great to get it in the 0.24.2. I tested it with both poetry==1.8.5 and poetry==2.1 and left a few comments, please have a look!

Copy link
Contributor

@henadzit henadzit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Should we release 0.24.2? Can you do it or do you want me to do it?

@waketzheng
Copy link
Contributor Author

waketzheng commented Mar 3, 2025 via email

@henadzit henadzit merged commit d5ea7c6 into tortoise:develop Mar 3, 2025
9 checks passed
@henadzit henadzit mentioned this pull request Mar 3, 2025
@waketzheng waketzheng deleted the add-project-section branch March 4, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run poetry add tortoise-orm with poetry 2.0+
3 participants